Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajout d'un nouveau référentiel : le Répertoire National des Fondations (RNF) #9648

Merged
merged 6 commits into from
Nov 8, 2023

Conversation

lisa-durand
Copy link
Contributor

closes #9404

Capture d’écran 2023-10-26 à 12 19 07 Capture d’écran 2023-10-26 à 12 19 19

@what-the-diff
Copy link

what-the-diff bot commented Oct 26, 2023

PR Summary

  • New RNF Component Added
    A set of new files have been introduced for a component named 'RNF'. These handle various aspects related to this component such as its model, services, views, and translations.

  • New Entries in Initializer Files
    Some additional configuration related to URLs and inflections has been incorporated into the relevant initializer files.

  • Translational Support Added
    Support for multilingual usage has been enhanced with the inclusion of new translations in the models and shared locales in both English and French.

  • Additional Testing Features
    New testing elements for RNF have been included, namely, tensorflow factories and fixtures that will assist in creating robust test scenarios.

  • Modifications in Existing Files
    Several existing app component files and controllers have been updated to accommodate the new RNF component feature. These files include champs_rows_show_component.html.haml, dossiers_controller.rb, champ.rb, and type_de_champ.rb.

By introducing these changes and additions, the product's versatility, user-friendliness, and test coverage should be expected to improve significantly.

@E-L-T E-L-T force-pushed the add-rnf-service branch 6 times, most recently from 62b706d to 999730f Compare October 27, 2023 13:08
@lisa-durand lisa-durand marked this pull request as ready for review October 30, 2023 09:44
@tchak
Copy link
Member

tchak commented Oct 31, 2023

Il faudrait ajouter aux données affichées la décomposition de l'adresse : INSEE et département. Ce serait bien aussi d'ajouter quelques colonnes aux exports (xls) : INSEE et département. Même chose sur l'API (mais on peut le faire dans une autre PR). De plus, étant donné que c'est un champ avec une adresse et donc un département, je l'ajouterais bien aux champs qui peuvent être utilisés dans le conditionnel et le routage (mais aussi plutôt dans une autre PR).

Copy link
Member

@LeSim LeSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super classe.

Alors, il faudrait une ptite modif dans la l'affichage en mode édition. SI j'ai bien compris. le but du formulaire est de permettre la mise a jour de des informations du rnf, du coup, il faudrait que l'usager voit ces informations y compris à l'édition.

on peut le faire dans une autre pr si vous voulez.

@lisa-durand
Copy link
Contributor Author

@tchak
Capture d’écran 2023-11-06 à 15 30 09
J'ai ajouté les 2 champs supplémentaires de l'adresse dans la vue. J'ai ensuite créé 2 tickets séparés pour tes 2 autres remarques #9670 #9671
Est-ce que ça te convient ?

@E-L-T E-L-T force-pushed the add-rnf-service branch 2 times, most recently from 0959f3d to 1ac51f3 Compare November 7, 2023 13:21
@E-L-T E-L-T added this pull request to the merge queue Nov 8, 2023
Merged via the queue into main with commit 0968f02 Nov 8, 2023
15 checks passed
@E-L-T E-L-T deleted the add-rnf-service branch November 8, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants